Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Fix text-shadow in WebVTT not working #5499

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 18, 2023

Fixes #5020

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Aug 18, 2023
@avelad avelad added this to the v4.4 milestone Aug 18, 2023
@avelad avelad merged commit ac6a92a into shaka-project:main Aug 18, 2023
19 of 22 checks passed
@avelad avelad deleted the vtt-text-shadow branch August 18, 2023 12:28
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 17, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
4 participants