Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebVTT): Add support to ruby, rt, rp html tags #5642

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 12, 2023

Related to #2853

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: WebVTT The issue involves WebVTT subtitles specifically labels Sep 12, 2023
@avelad avelad added this to the v4.5 milestone Sep 12, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 90.00%

# Conflicts:
#	lib/text/vtt_text_parser.js
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I had never known that was called a "ruby".

@avelad avelad merged commit 76ffd38 into shaka-project:main Sep 12, 2023
16 of 17 checks passed
@avelad avelad deleted the webvtt-ruby-tags branch September 12, 2023 12:29
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 11, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
3 participants