Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(WebVTT): Refactor how nestedCues are handled in WebVTT #5663

Merged
merged 3 commits into from
Sep 15, 2023
Merged

refactor(WebVTT): Refactor how nestedCues are handled in WebVTT #5663

merged 3 commits into from
Sep 15, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 15, 2023 •
edited
Loading

This change makes WebVTT more similar to how nestedcues are managed in TTML.
@avelad avelad added priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Sep 15, 2023
@avelad avelad added this to the v4.5 milestone Sep 15, 2023
@avelad avelad changed the title chore(WebVTT): Refactor how nestedCues are handled in WebVTT Sep 15, 2023
theodab
theodab requested changes Sep 15, 2023
View reviewed changes
lib/text/vtt_text_parser.js Outdated Show resolved Hide resolved
test/text/vtt_text_parser_unit.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab September 15, 2023 11:23
@avelad avelad requested a review from theodab September 15, 2023 11:24
@avelad
Copy link
Collaborator Author

avelad commented Sep 15, 2023

I'll wait to pass all test to merge it. Thanks @theodab !
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%
@avelad avelad merged commit f55c6ab into shaka-project:main Sep 15, 2023
16 checks passed
@avelad avelad deleted the nestedcues-webvtt branch September 15, 2023 12:32
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 14, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated
3 participants
@avelad @shaka-bot @theodab