Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTT): fix setting textShadow when multiple CSS classes provided #6287

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

tykus160
Copy link
Contributor

No description provided.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad
Copy link
Collaborator

avelad commented Feb 23, 2024

Can you add a test? Thanks!

@tykus160 tykus160 changed the title fix(VTT): fix setting textShadow from multiple CSS classes Feb 23, 2024
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Feb 26, 2024
@avelad avelad added this to the v5.0 milestone Feb 26, 2024
@avelad avelad merged commit d0e64d7 into shaka-project:main Feb 26, 2024
18 checks passed
joeyparrish pushed a commit that referenced this pull request Feb 27, 2024
@tykus160 tykus160 deleted the wt-text-shadow-fix branch April 5, 2024 05:16
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
3 participants