Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebVTT): Remove rollover logic because we always transmux TS #6397

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(WebVTT): Remove rollover logic because we always transmux TS #6397

merged 1 commit into from
Apr 4, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 3, 2024

Fixes #6320
@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release component: WebVTT The issue involves WebVTT subtitles specifically labels Apr 3, 2024
@avelad avelad added this to the v5.0 milestone Apr 3, 2024
@avelad avelad requested a review from joeyparrish April 3, 2024 12:09
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%
@avelad avelad merged commit 286126e into shaka-project:main Apr 4, 2024
21 checks passed
@avelad avelad deleted the vtt-rollover branch April 4, 2024 08:24
@shaka-bot shaka-bot mentioned this pull request Apr 4, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(WebVTT): Remove rollover logic because we always transmux TS (#6397)
9ab54d1 
Fixes #6320
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(WebVTT): Remove rollover logic because we always transmux TS (#6397)
6610c22 
Fixes #6320
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format component: WebVTT The issue involves WebVTT subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
3 participants
@avelad @shaka-bot @theodab