Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #242

Merged
merged 2 commits into from
Oct 3, 2020
Merged

Update README.md #242

merged 2 commits into from
Oct 3, 2020

Conversation

rohit404404
Copy link
Contributor

made videos path clear

made videos path clear
@rohit404404 rohit404404 marked this pull request as ready for review October 3, 2020 18:39
Copy link
Collaborator

@lukaarma lukaarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, just a minor change

README.md Outdated
@@ -214,7 +214,7 @@ iTerm2 on a Mac -

![screenshot](assets/screenshot-mac.png)

By default, downloads are saved under `videos/` unless specified by `-o` (output directory).
By default, downloads are saved under `videos/` ( Not a system media Videos folder ), unless specified by `-o` (output directory).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if you changed from videos to Destreamer/videos because that comment may leave some users confused on were it's the folder.
And maybe rephrase from 'not a system...' to 'not the system...'

made videos path clearer
Copy link
Collaborator

@lukaarma lukaarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@lukaarma lukaarma merged commit ec24ff9 into snobu:master Oct 3, 2020
@lukaarma lukaarma mentioned this pull request Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants