Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharepoint branch updated to work on M1/M2 macs #490

Open
wants to merge 3 commits into
base: sharepoint
Choose a base branch
from
Open

Sharepoint branch updated to work on M1/M2 macs #490

wants to merge 3 commits into from

Commits on Jun 24, 2023

  1. Updated NPM packages as of June 2023 

    ran npm update --save.
    @hakt0-r
    hakt0-r committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    fa2509b View commit details
    Browse the repository at this point in the history

  2. some of the JS libraries do not have type definition files(.d.ts) 

    when running npm run build you'll get a quite a few errors that talk about missing type definition files... They are not not missing... just adding one line 
"noImplicitAny": false
in tsconfig.json file suppresses those messages.
    @hakt0-r
    hakt0-r committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    d1c0391 View commit details
    Browse the repository at this point in the history

  3. Fixing a couple of issues here... 

    src/LoginModules.ts:14:20 - error TS2503: Cannot find namespace 'puppeteer'.
src/TokenCache.ts:60:20 - error TS2503: Cannot find namespace 'puppeteer'.
and...
src/TokenCache.ts:99:24 - error TS2339: Property 'waitFor' does not exist on type 'Page'.

These are fixed by simple oneliner changes.
    @hakt0-r
    hakt0-r committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    c46f219 View commit details
    Browse the repository at this point in the history