robustify the debug and error reports #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type-analysis debug report used to crash on various assertions because it assumed a well-typed program. However the first type-analysis runs before the semantics checker, hence the program may be ill-typed at that time. With this change the type-analysis debug report printer makes no assumptions about the expected types, instead it prints the infered types.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2495 +/- ##
==========================================
+ Coverage 77.49% 81.09% +3.60%
==========================================
Files 492 492
Lines 30934 30908 -26
==========================================
+ Hits 23972 25066 +1094
+ Misses 6962 5842 -1120
|
julienhenry
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Robustify the generation of debug and error reports.
Updated the CI to enable debug reporting on all tests for the linux + coverage build.
Added build option
SOUFFLE_TEST_DEBUG_REPORT=ON|OFF(OFFby default), that enables debug reporting on all tests.