-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANCHOR-622] Redefine clients configuration with a schema and a separate file #1306
base: feature/v3
Are you sure you want to change the base?
[ANCHOR-622] Redefine clients configuration with a schema and a separate file #1306
Conversation
assets: | ||
# The type of the assets definition. | ||
# The type of the asset definition. | ||
# `type` can be one of the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will drop in-place assets definition which is a feature not used.
Configuration for Stellar anchor clients, distinguishing between custodial and non-custodial clients. | ||
properties: | ||
custodial_clients: | ||
type: array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: List? Let's unify the terminology :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use plural for list. Can you help pointing out the inconsistencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I mean since it is described as List
(List of custodial clients. Defaults to an empty list), shall we just use type List
instead of Array
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see there is a type list in OpenAPI spec though. https://swagger.io/docs/specification/data-models/data-types/
Can you help to give me the reference?
Description
Redefine clients configuration with a schema and a separate file
Context
For version 3.0.0
Testing
./gradlew test
Documentation
TODO: If this pull request adds a feature, describe changes to documentation that has been made