-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CEA608/708 parser #75
feat: CEA608/708 parser #75
Conversation
29d221a
to
8945ae1
Compare
Signed-off-by: hernan <hernanr@qualabs.com>
…tputFilter instance Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
8945ae1
to
a5c9def
Compare
Signed-off-by: hernan <hernanr@qualabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One question, do you support the subtitles described in videojs/mux.js#439 ? |
Hey @avelad, do you have a playlists we could test with? Or should we try with the one on that PR? |
Yes, you can use: |
…eature/cea-608-708 Signed-off-by: hernan <hernanr@qualabs.com>
We've tried with that one but it doesn't seem to have a subtitle playlist. Could you provide us another one? Or what specific type of subtitle should we test? |
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com> Signed-off-by: Felipe Young <felipey@qualabs.com> Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: Felipe Young <felipey@qualabs.com> Co-authored-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
…tputFilter instance Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com> Signed-off-by: Felipe Young <felipey@qualabs.com> Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: Felipe Young <felipey@qualabs.com> Co-authored-by: hernan <hernanr@qualabs.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…on-media-library into feature/cea-608-708 Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> # Conflicts: # CHANGELOG.md # lib/src/id3/util/utf8.ts
94744b5
into
streaming-video-technology-alliance:feat/608
* Added CEA-608/708 methods Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* Added CEA-608/708 methods Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* feat: CTA-608parser (#75) --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Co-authored-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Co-authored-by: Agajan J <agajan.tm@gmail.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* feat: CTA-608parser (#75) --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Co-authored-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Co-authored-by: Agajan J <agajan.tm@gmail.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…se/0.7.0 * feat: CEA608/708 parser (#75) (#86) * feat: CTA-608parser (#75) --------- Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Signed-off-by: Nicolas Levy <nicolas@qualabs.com> Signed-off-by: Noelia Bentancor <71080743+NoeliaBentancor@users.noreply.github.com> Signed-off-by: Agajan Jumakuliyev <agajan.tm@gmail.com> Co-authored-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Co-authored-by: Nicolas Levy <nicolaslevylinares@gmail.com> Co-authored-by: Noelia Bentancor <71080743+NoeliaBentancor@users.noreply.github.com> Co-authored-by: DuckyCB <duckycb@proton.me> Co-authored-by: Matías Rodriguez <matiasnrb97@gmail.com> Co-authored-by: Matías Rodriguez <37405481+matiasrb97@users.noreply.github.com> Co-authored-by: Patricio Carrau <66135366+DuckyCB@users.noreply.github.com> Co-authored-by: Agajan J <agajan.tm@gmail.com>
Description
We've implemented support for the CEA608/708 subtitles standard to our library, expanding its capabilities. In this update, alongside the feature implementation, we've initiated the integration with a basic set of tests.
Requirements Checklist