This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
feat(FormInput): add validation properties #386
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey guys, just checking in to see about this getting merged. If there's something wrong with it then no worries. I'm aware that it potentially may be "more tabler" to handle this stuff in Javascript. |
|
Please, I need it. |
|
Hello @nating @NickAlvesX I apologize for taking so long to get to this. I have been a bit busier than usual lately. I am going to merge this for now, but I do agree with @nating that there might be a friendlier way to do this with Javascript as opposed to relying on html form properties. So that may be something to explore in the future. |
AaronCoplan
approved these changes
Jan 29, 2019
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR adds the following validation properties to the FormInput component:
Demonstration:
Here is a GIF in which FormInput components are given these properties and inputs that are not valid according to these properties are shown to resolve in errors when the form is submit.
PS. (The GIF slowed down with the compression / format conversion somewhere along the way so it's a bit slow)