Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Fix string format not support keywords format #3256

Merged
merged 2 commits into from
Oct 25, 2021
Merged

[Lang] Fix string format not support keywords format #3256

merged 2 commits into from
Oct 25, 2021

Conversation

yihong0618
Copy link
Collaborator

Related issue = #2552

test here

@ti.kernel
def func(k: ti.f32):
    print(123)
    print("{} abc".format(123))
    print("{} {} {}".format(1, 2, 3))
    print("{} {name} {value}".format(k, name=999, value=123))
    name = 123.4
    value = 456.7
    print("{} {name} {value}".format(k, name=name, value=value))

func(233.3)
@netlify
Copy link

netlify bot commented Oct 23, 2021

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: 1ff57c0

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61738970e7f89300078bedea

@k-ye k-ye requested a review from Leonz5288 October 23, 2021 12:27
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/python/test_print.py Show resolved Hide resolved
Copy link
Contributor

@Leonz5288 Leonz5288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit fac2118 into taichi-dev:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants