Editorial: Factor out AO RunSuspendedContext() #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
e3e0a00
to
2586002
Compare
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
2586002
to
1bb271e
Compare
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
1bb271e
to
4e953c2
Compare
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
4e953c2
to
fe05833
Compare
spec.html
Outdated
| 1. Push _asyncContext_ onto the execution context stack; _asyncContext_ is now the running execution context. | ||
| 1. <emu-meta effects="user-code">Resume the suspended evaluation of _asyncContext_</emu-meta> using NormalCompletion(_value_) as the result of the operation that suspended it. | ||
| 1. Assert: When we reach this step, _asyncContext_ has already been removed from the execution context stack and _prevContext_ is the currently running execution context. | ||
| 1. Perform Completion(RunSuspendedContext(_asyncContext_, NormalCompletion(_value_))). |
There was a problem hiding this comment.
Yes it does, e.g.: error: RunSuspendedContext returns a Completion Record, but is not consumed as if it does (typecheck) at spec.html:46018:24
jmdyck
force-pushed
the
RunSuspendedContext
branch
2 times, most recently
from
ed3013c
to
4cfe666
Compare
|
This PR's |
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
4cfe666
to
a05d197
Compare
... over both arms of the subsequent "If"
... because ExecuteModule does it before calling AsyncBlockStart, so it seems like AsyncFunctionStart would have to as well. (The semantics of "Suspend" are fuzzy, but this seems innoccuous to me.)
From: immediately before calls to AsyncBlockStart() To: just inside AsyncBlockStart()
This gets things ready for the refactoring that the next commit will do. It's mostly just moving certain steps earlier or later.
jmdyck
force-pushed
the
RunSuspendedContext
branch
from
a05d197
to
c6bc612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't address the semantics of Suspend/Resume, just factors out a common chunk of code.
This PR is split into 6 commits where it's easier to confirm the correctness. They're probably fine to be squashed before landing.