Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix absolute paths #41

Merged
merged 2 commits into from
Feb 23, 2019
Merged

Fix absolute paths #41

merged 2 commits into from
Feb 23, 2019

Conversation

ForsakenHarmony
Copy link
Contributor

Fixes #35
lukeed
lukeed reviewed Feb 22, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@lukeed @ForsakenHarmony
Update index.js
72c61d6 
Co-Authored-By: ForsakenHarmony <me@hrmny.sh>
@ForsakenHarmony
Copy link
Contributor Author

welp, this broke some tests
@terkelg
Copy link
Owner

terkelg commented Feb 23, 2019

Thank you for the PR @ForsakenHarmony. Sorry I've been busy relocating. Not sure why the tests broke. It's been a while since I've done any work on Tiny Glob
@ForsakenHarmony
Copy link
Contributor Author

Master is actually broken 🙃

guess some update was breaking but not published as breaking
lukeed
lukeed approved these changes Feb 23, 2019
View reviewed changes
Copy link
Collaborator

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this, thank you 😄

Addressing the tests/broken bits separately. The weird part is that TravisCI history is all green 🤔
@lukeed lukeed merged commit c532217 into terkelg:master Feb 23, 2019
@ForsakenHarmony
Copy link
Contributor Author

it's globalyzer, 2 published versions

0.1.0 works fine
0.1.4 doesn't, no changelog either @terkelg 👀
@lukeed
Copy link
Collaborator

lukeed commented Feb 23, 2019

Yup! On it now
@reznord reznord mentioned this pull request Mar 5, 2019
Merged
@benmccann benmccann mentioned this pull request Nov 19, 2020
Merged
@benmccann
Copy link
Contributor

More info about the test failures here, which are unrelated to this change: https://github.com/terkelg/tiny-glob/pulls#issue-524201732

This PR did have one issue I found though which is that it updated index.js and not sync.js: #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@ForsakenHarmony @terkelg @lukeed @benmccann