feat: support cilium clusterwide #1973
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled support for CiliumClusterWideNetworkPolicy across various Terraform modules to enhance network security and policy enforcement capabilities in Kubernetes clusters. This change allows for the utilization of Cilium's extended network policy features, providing users with the option to enforce more granular network policies at the cluster level. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Aligned variable assignments across multiple Terraform modules to enhance readability and maintain consistency in the codebase. This change ensures that the code formatting follows best practices, making it easier for developers to understand and maintain the infrastructure as code. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
…modules Ensured consistency in the default behavior of CiliumClusterWideNetworkPolicy across various Terraform modules by setting its default value to false. This change aligns the modules' configurations with best practices for optional features, providing a safer default configuration for users. Signed-off-by: Matthis Holleville <matthish29@gmail.com>
matthisholleville
requested review from
ericyz,
gtsorbo and
a team
as code owners
apeabody
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Thanks for the contribution @matthisholleville!
Can you please make your change in the source template as described here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled support for CiliumClusterWideNetworkPolicy across various Terraform modules to enhance network security and policy enforcement capabilities in Kubernetes clusters. This change allows for the utilization of Cilium's extended network policy features, providing users with the option to enforce more granular network policies at the cluster level.
In link with https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#enable_cilium_clusterwide_network_policy