fix: Node Pool enable_gcfs true:false #1976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this currently sets enable_gcfs either to true or null which can cause node pools that are set to false to be recreated
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
apeabody
requested changes
Jun 22, 2024
There was a problem hiding this comment.
Thanks for the contribution @psiegmannyardi!
Please see my initial note below on the examples
| source = "terraform-google-modules/kubernetes-engine/google" | ||
| version = "~> 31.0" | ||
| source = "../../.." | ||
| # [restore-marker] version = "~> 31.0" |
There was a problem hiding this comment.
Looks like these "leaked" from a test and will need to be reverted.
There was a problem hiding this comment.
@apeabody I think I got them reverted to the state you want
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently enable_gcfs is either set to true or null which can cause node pools that are set to false to be recreated. This will change it to either be true or false