fix: empty addons_config handling

[0Delta]

resolve #1716

Older clusters may have missing or missing values in google_container_cluster.primary.addons_config.
The current code assumes that the value is sufficient and cannot resolve this.

This patch will reduce dirty hacks such as pulling and modifying this repo and importing.

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @0Delta!

Please see the linter output for change.

[0Delta]

I have fixed the points you pointed out, apologize for my bad format.

[apeabody]

From the linter:

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/main.tf /tmp/tmp.xMCHtY7AKG/workspace/main.tf
121,123c121,123
<   cluster_output_network_policy_enabled             = coalescelist(lookup(coalescelist(google_container_cluster.primary.addons_config, [{}])[0], "network_policy_config", [{}]), [{ disabled = false }])[0].disabled
<   cluster_output_http_load_balancing_enabled        = coalescelist(lookup(coalescelist(google_container_cluster.primary.addons_config, [{}])[0], "http_load_balancing", [{}]), [{ disabled = false }])[0].disabled
<   cluster_output_horizontal_pod_autoscaling_enabled = coalescelist(lookup(coalescelist(google_container_cluster.primary.addons_config, [{}])[0], "horizontal_pod_autoscaling", [{}]), [{ disabled = false }])[0].disabled
---
>   cluster_output_network_policy_enabled             = google_container_cluster.primary.addons_config[0].network_policy_config[0].disabled
>   cluster_output_http_load_balancing_enabled        = google_container_cluster.primary.addons_config[0].http_load_balancing[0].disabled
>   cluster_output_horizontal_pod_autoscaling_enabled = google_container_cluster.primary.addons_config[0].horizontal_pod_autoscaling[0].disabled
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

[0Delta]

Linter indicates the previous code, indicating that existing problems are not solved.
Which is better to ask Linter ignoring only this section or design a code that makes Linter in a good mood?

[apeabody]

Linter indicates the previous code, indicating that existing problems are not solved. Which is better to ask Linter ignoring only this section or design a code that makes Linter in a good mood?

Hi @0Delta - It appears the templates haven't been updated. Please see here for details: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating. Thanks!

[0Delta]

I finally found out what this repository was made up of.
Thank you @apeabody for the detailed guide.

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @0Delta!