Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional functionality for autopilot clusters #1985

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

kliu47
Copy link
Contributor

@kliu47 kliu47 commented Jul 2, 2024

Additionally GA functionality for GKE autopilot modules:

@kliu47 kliu47 changed the title Add additional functionality for autopilot clusters Jul 2, 2024
@kliu47 kliu47 marked this pull request as ready for review July 2, 2024 21:36
@kliu47 kliu47 requested review from ericyz, gtsorbo and a team as code owners July 2, 2024 21:36
@kliu47
Copy link
Contributor Author

kliu47 commented Jul 2, 2024

Updated the test in simple_autopilot_public as an example of enabling gcs_fuse

@kliu47 kliu47 force-pushed the dev branch 2 times, most recently from 51fdf95 to 8e10abb Compare July 2, 2024 22:45
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kliu47!

I've noted some initial feedback on whitespace and triggered the CI tests.

/gcbrun

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
autogen/main/cluster.tf.tmpl Show resolved Hide resolved
autogen/main/variables.tf.tmpl Outdated Show resolved Hide resolved
@apeabody
Copy link
Contributor

apeabody commented Jul 2, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Jul 3, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Jul 3, 2024

From the linter:

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/instance_template/README.md /tmp/tmp.WhX65XKh44/workspace/modules/instance_template/README.md
23c23
< | description | The template's description | `""` |`string` | no |
---
> | description | The template's description | `string` | `""` | no |
33c33
< | instance\_description | Description of the generated instances | `""` | `string` | no |
---
> | instance\_description | Description of the generated instances | `string` | `""` | no |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
/usr/local/bin/task_helper_functions.sh: line 30: DELETE_AT_EXIT: readonly variable
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/instance_template/README.md /tmp/tmp.IrquMowoNu/generate_docs/workspace/modules/instance_template/README.md
23c23
< | description | The template's description | `""` |`string` | no |
---
> | description | The template's description | `string` | `""` | no |
33c33
< | instance\_description | Description of the generated instances | `""` | `string` | no |
---
> | instance\_description | Description of the generated instances | `string` | `""` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
@kliu47
Copy link
Contributor Author

kliu47 commented Jul 4, 2024

Weird that the linter is asking me to re-run make build and make generate docs. Tried both and VCS is showing no changes to commit.

@apeabody
Copy link
Contributor

apeabody commented Jul 8, 2024

Weird that the linter is asking me to re-run make build and make generate docs. Tried both and VCS is showing no changes to commit.

Interesting, I don't think your PR should impact those lines. Re-running

/gcbrun

@apeabody apeabody dismissed their stale review July 8, 2024 20:27

ready for code review

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @kliu47!

@apeabody apeabody merged commit 3b0bbe8 into terraform-google-modules:master Jul 8, 2024
4 checks passed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants