-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply openapi_prefix to redirect URL #1159
Conversation
Travis build was failing because of this:
I don't really understand how these type checkers work, but it doesn't seem to me that Optional[str] is the appropriate choice, given that swagger_ui_oauth2_redirect_url is never None and has a default value of type str. |
Build is still failing and I'm trying to find what is wrong since the 3 first builds don't explicitly say which error was raised. |
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 331 223 -108
Lines 8085 6668 -1417
===========================================
- Hits 8085 6668 -1417
Continue to review full report at Codecov.
|
Duplicate of #1199 |
Thanks for your work @littlebrat ! Clever implementation. But yeah, with #1199 we can handle the issue from the "root" 😄 |
For my application I need to use Apache as a Reverse Proxy, like this:
In order to do this, I have to setup the fastapi app with the following settings:
The openapi_prefix is needed to set up the application behind a reverse proxy as carefully explained in FastApi documentation, otherwise
openapi.json
is not served in the right place. But, for some reason this openapi_prefix was not being applied on the oauth2 redirect_uri in the swagger html generator.