Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML report generated with wily report --format HTML has spurious characters around the colored delta:
wily report --format HTML
It comes from an incomplete text replacement in src/wily/commands/report.py:
wily/src/wily/commands/report.py
Line 181 in 72c4bb8
Given that element above was constructed as below, there's a \u001b character that doesn't get replaced:
element
\u001b
Line 124 in 72c4bb8
To Reproduce
wily build
wily report -n 135 --format HTML src\wily\commands\report.py loc
Expected behavior Deltas should still be colored, but without spurious characters around them, as below:
Desktop (please complete the following information):
I have a trivial fix, will submit PR.
The text was updated successfully, but these errors were encountered:
Merge pull request #185 from devdanzin/fix_spurious_characters
70ce4da
HTML report: replace ESCAPE character (fix #184)
HTML report generated with
![spurious_characters](https://cdn.statically.io/img/private-user-images.githubusercontent.com/74280297/251174816-e1023e2d-9323-4d7f-a4f7-c96a9e65274f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NjU2MDgsIm5iZiI6MTcyMTQ2NTMwOCwicGF0aCI6Ii83NDI4MDI5Ny8yNTExNzQ4MTYtZTEwMjNlMmQtOTMyMy00ZDdmLWE0ZjctYzk2YTllNjUyNzRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDA4NDgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlZWI2NGNhZGU0MjFlNjJiMmZlNTcxNmQ0MTJkMDZjMWNlZTQxODRjOGQyYTM2MDUyMDFlOGY3MjkxNTI1YTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xiswc-cHeoIAX9PX4_wFUmDqiG6wKGRF7TkRMiYbhvw)
wily report --format HTML
has spurious characters around the colored delta:It comes from an incomplete text replacement in src/wily/commands/report.py:
wily/src/wily/commands/report.py
Line 181 in 72c4bb8
Given that
element
above was constructed as below, there's a\u001b
character that doesn't get replaced:wily/src/wily/commands/report.py
Line 124 in 72c4bb8
To Reproduce
wily build
wily report -n 135 --format HTML src\wily\commands\report.py loc
\u001b
characters around delta in e.g. rev a96280e.Expected behavior
![no_spurious_characters](https://cdn.statically.io/img/private-user-images.githubusercontent.com/74280297/251174809-a50ffb1e-d525-4f24-a72c-c7ad98aa3093.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0NjU2MDgsIm5iZiI6MTcyMTQ2NTMwOCwicGF0aCI6Ii83NDI4MDI5Ny8yNTExNzQ4MDktYTUwZmZiMWUtZDUyNS00ZjI0LWE3MmMtYzdhZDk4YWEzMDkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDA4NDgyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA1YzcwNjIwNDRhNmI3ZWNhM2I2MzA0NGMyY2Y2M2MwOTBiYTlhODMyNWY5OTJmYTc2OWUyYjBiY2U5ZWRlNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MNXk-TEmk8IfUAsw6ONcRMwryy9cih2r7bPw7wsKHAM)
Deltas should still be colored, but without spurious characters around them, as below:
Desktop (please complete the following information):
I have a trivial fix, will submit PR.
The text was updated successfully, but these errors were encountered: