Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log calls should all be lazy-formatted #219

Closed
tonybaloney opened this issue Sep 4, 2023 · 0 comments · Fixed by #220
Closed

Log calls should all be lazy-formatted #219

tonybaloney opened this issue Sep 4, 2023 · 0 comments · Fixed by #220
Assignees
@devdanzin

Comments

@tonybaloney
Copy link
Owner

I've noticed that the logger.debug() calls throughout the codebase use f-strings.

This isn't ideal because it eagerly formats the message even when logging isn't in debug mode.

It should use % style messages with the arguments as parameters. There is a pylint check for this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@tonybaloney @devdanzin