Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy-format all logging calls (fix #219) #220

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

devdanzin
Copy link
Collaborator

This PR converts wily's logging from using f-strings to % style messages.
Fixes #219.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 92.45% and project coverage change: -2.75% ⚠️

Comparison is base (099bc78) 95.84% compared to head (0469442) 93.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   95.84%   93.10%   -2.75%     
==========================================
  Files          25       25              
  Lines        1349     1349              
  Branches      289      289              
==========================================
- Hits         1293     1256      -37     
- Misses         32       68      +36     
- Partials       24       25       +1     
Files Changed Coverage Δ
src/wily/operators/halstead.py 43.33% <0.00%> (-46.67%) ⬇️
src/wily/operators/maintainability.py 72.00% <0.00%> (-28.00%) ⬇️
src/wily/operators/raw.py 63.15% <0.00%> (-36.85%) ⬇️
src/wily/commands/diff.py 89.53% <66.66%> (ø)
src/wily/__main__.py 95.69% <100.00%> (ø)
src/wily/archivers/git.py 87.65% <100.00%> (ø)
src/wily/cache.py 97.32% <100.00%> (ø)
src/wily/commands/build.py 92.78% <100.00%> (ø)
src/wily/commands/index.py 100.00% <100.00%> (ø)
src/wily/commands/rank.py 96.61% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonybaloney
Copy link
Owner

thanks for doing this

@tonybaloney tonybaloney merged commit ec49511 into tonybaloney:master Sep 6, 2023
18 checks passed
@devdanzin devdanzin deleted the lazy_logging branch September 25, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants