Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for aggregated graphs + patch title #138

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

ThomasTNO
Copy link
Contributor

This pull request implements aggregated graph support for directories.

It also patches a bug in title creation.

@tonybaloney
Copy link
Owner

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #138 (f99d09d) into master (e72b7d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   97.82%   97.83%           
=======================================
  Files          23       23           
  Lines        1152     1153    +1     
=======================================
+ Hits         1127     1128    +1     
  Misses         25       25           
Impacted Files Coverage Δ
src/wily/__main__.py 98.31% <100.00%> (+<0.01%) ⬆️
src/wily/commands/graph.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72b7d9...f99d09d. Read the comment docs.

@ThomasTNO
Copy link
Contributor Author

Thanks! Please can you add a basic test in https://github.com/tonybaloney/wily/blob/master/test/integration/test_graph.py

Added two basic tests

@ThomasTNO
Copy link
Contributor Author

Attempted to patch the labels of data points, but it still seems bugged.

@ThomasTNO
Copy link
Contributor Author

Attempted to patch the labels of data points, but it still seems bugged.

Should be working properly now.

@tonybaloney tonybaloney merged commit fc4d5e4 into tonybaloney:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants