-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch aggregate statistics #139
Patch aggregate statistics #139
Conversation
…oved, deleted, deeper nested etc.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 97.82% 97.04% -0.79%
==========================================
Files 23 23
Lines 1152 1183 +31
==========================================
+ Hits 1127 1148 +21
- Misses 25 35 +10
Continue to review full report at Codecov.
|
I fixed most unit tests, two failing tests remaining. Feel free to suggest a solution to those. |
Thanks for this! Since this changes the wily cache spec, have you tested what happens when you have a cache built with an older version? |
I did not test this. I guess that fails, as the |
I just ran it on cache built with an older version, it seems to just work fine. |
I discovered that the aggregated statistics were not properly computed.
In particular in case of file movements, file deletions and deeply nested directories.
This PR should resolve the issue. Please validate if this does not break other functionality (as I am relatively new to the code base.)