pyupgrade --py37-plus #153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 97.36% 97.36% -0.01%
==========================================
Files 23 23
Lines 1214 1213 -1
==========================================
- Hits 1182 1181 -1
Misses 32 32
Continue to review full report at Codecov.
|
src/wily/commands/diff.py
Outdated
| "{0:n} -> \u001b[{2}m{1:n}\u001b[0m".format( | ||
| current, new, GOOD_COLORS[metric.measure] | ||
| ) | ||
| f"{current:n} -> [{GOOD_COLORS[metric.measure]}m{new:n}[0m" |
There was a problem hiding this comment.
Please verify that you've run this wily diff on a project and check that the colors are rendering correctly. In GitHub diff this looks like an invalid character
There was a problem hiding this comment.
pyupgrade is conservative in f-string conversions. -- The first commit.
flynt is more aggressive (perhaps overly) -- The second commit. I think I will revert the flynt changes.
|
thanks for the PR |
tonybaloney#153 makes https://pypi.org/project/mock unnecessary. > mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.
https://pypi.org/project/pyupgrade
https://pypi.org/project/flynt
https://pypi.org/project/mock vs. https://docs.python.org/3/library/unittest.mock.html