-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve CI and local development #157
refactor: improve CI and local development #157
Conversation
Section `[build-system]` is used by `pip` to properly build package managed by `flit`. Package's dependencies are taken from section `[tool.flit.metadata].requires`. This commit fixes: tonybaloney#142 References: + https://flit.pypa.io/en/latest/pyproject_toml.html#build-system-section + https://flit.pypa.io/en/latest/pyproject_toml.html#pyproject-old-metadata + tonybaloney#142
Currently all linters or tests should be run locally using `Makefile`.
e6a849f
to
8c852b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 97.36% 95.05% -2.31%
==========================================
Files 23 23
Lines 1213 1214 +1
Branches 0 290 +290
==========================================
- Hits 1181 1154 -27
- Misses 32 34 +2
- Partials 0 26 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I don't know why tests run on windows are failing, if you have any idea please share! |
There's a lot going on in this PR making it really hard to review. Could you please cherry-pick these commits into atomic changes i.e. one pull-request = one concern |
Yes, there is a log going on in this PR, but I have made atomic changes on the commit level, so you can review one commit after another. However, if it's still hard to review let me know and I will try to split it into multiple PRs with atomic changes ;) |
1 test is failing on Windows:
|
Yes, but unfortunately, I don't know why it's failing at first sight and I don't have access to a windows machine so I can dig into this test more deeply. |
But this test is also failing on the main branch, let's check it here |
Ok. I have a windows machine, will test on that and make sure it's unrelated so we can merge this 👍🏻 |
This PR is quite big and changes several things:
pyproject.toml
using flit extrasMakefile
flit
andMakefile
should be used for local development)main
andlint_python
workflowsThings to do (but probably in separate PRs):
.editorconfig
and clean whitespaces in the codebase - check feat: add .editorconfig #158.gitignore
(e.g. withwily_report
andfoo
)black
configuration, apply it on the codebase and require it inMakefile
isort
configuration, apply it on the codebase and require it inMakefile
ignore
in its config and set its proper configurationcodespell
configuration, apply it on the codebase and require it inMakefile
mypy
configuration, resolve its issues and require it inMakefile
pytest
plugins, likepytest-timeout
orpytest-randomly