Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xmlcharrefreplace to handle codec errors in html report writing (fix #182) #183

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

devdanzin
Copy link
Collaborator

To fix #182, use errors="xmlcharrefreplace" in Path.open() so we avoid the error and the generated HTML works.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #183 (b0d65f4) into master (72c4bb8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          23       23           
  Lines        1214     1214           
  Branches      273      273           
=======================================
  Hits         1156     1156           
  Misses         33       33           
  Partials       25       25           
Impacted Files Coverage Δ
src/wily/commands/report.py 96.96% <100.00%> (ø)
@tonybaloney
Copy link
Owner

Thanks @devdanzin for the contribution. LGTM

@tonybaloney tonybaloney merged commit b19ee72 into tonybaloney:master Jul 10, 2023
18 checks passed
@devdanzin devdanzin deleted the fix_unicode_errors branch July 10, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants