Avoid using unicode characters if sys.stdout
doesn't support them (fix #65)
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When piping wily's output (and in other related scenarios) in Windows, users get a
UnicodeEncodeError: 'charmap' codec can't encode characters...
error. This happens because theDEFAULT_GRID_STYLE
is"fancy_grid"
, which uses characters outside of what charmap can understand.This PR introduces checks for
sys.stdout.encoding
and, if it's not UTF-8, makes wily pass"grid"
instead of"fancy_grid"
to tabulate astablefmt
. It gives comparable output with ASCII-only characters.Output should be testable once #199 lands.
Fixes #65.