Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix halstead harvester for errors thrown by radon #63

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 6, 2019

Similar to the fix for cyclomatic complexity here:
7ba461c

the radon halstead harvester can return errors as a piece of data and we
need to log it rather than attempt to add it to our report.

Similar to the fix for cyclomatic complexity here:
7ba461c

the radon halstead harvester can return errors as a piece of data and we
need to log it rather than attempt to add it to our report.
@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #63 into master will decrease coverage by 0.21%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   99.46%   99.24%   -0.22%     
==========================================
  Files          20       20              
  Lines         930      933       +3     
==========================================
+ Hits          925      926       +1     
- Misses          5        7       +2
Impacted Files Coverage Δ
wily/operators/halstead.py 93.1% <33.33%> (-6.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a681b...b71fa4d. Read the comment docs.

@tonybaloney
Copy link
Owner

thanks @abadger I'd never come across errors in this harvester

@tonybaloney tonybaloney merged commit 2992b15 into tonybaloney:master Mar 9, 2019
@abadger
Copy link
Contributor Author

abadger commented Mar 10, 2019

Thanks for merging! I was running it from the root of my project and it turned up errors in some of my pip installed dependencies (urwid was one of them, i think). Once i could see the error, i started running wily on the specific directories that hold my code ;-)

@tonybaloney
Copy link
Owner

released in 1.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants