Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift-syntax 510 #255

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

sidepelican
Copy link
Collaborator

Update swift-syntax.
No codebase changes were necessary.

dependencies: [
.package(url: "https://github.com/apple/swift-syntax.git", exact: "509.0.0"),
.package(url: "https://github.com/apple/swift-syntax.git", from: "510.0.1"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,
I think it's better to lock to a specific version of swift-syntax to avoid issues with transient dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an old style. Please take a look at the latest swift-syntax.

Copy link
Collaborator

@uhooi uhooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@sidepelican sidepelican merged commit 41c09bb into uber:master Apr 19, 2024
4 checks passed
@sidepelican sidepelican deleted the swiftsyntax510 branch April 19, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants