Remove implicit LocaleFallbackProvider constructors
#5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
fallbackctor
branch
3 times, most recently
from
bd6050e
to
66f4b31
Compare
robertbastian
force-pushed
the
fallbackctor
branch
from
66f4b31
to
b8d6336
Compare
sffc
approved these changes
Jul 8, 2024
| Struct, | ||
| compact | ||
| )] | ||
| pub fn enable_locale_fallback(&mut self) -> Result<(), ICU4XDataError> { |
There was a problem hiding this comment.
Not 100% sure we want to bring the change to FFI since the alternative may be less efficient (an extra allocation and FFI call), but it seems like something we could add back later if needed
There was a problem hiding this comment.
Fewer mutable methods over FFI is better anyway
Manishearth
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
LocaleFallbackeris an explicit argument toExportDriver, it might make sense to always make it explicit on theLocaleFallbackProvideras well.The
_unstable,_with_buffer_provider, and_with_any_providerconstructors are a bit odd for this crate anyway, no other adapter has the constructor trinity. Removing them also has the added benefit of removing theserdefeature from the crate.