Add a bin file to enable command-line decryption #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ | |||
| "github": "https://github.com/bcasey" | |||
| } | |||
| ], | |||
| "bin": "./bin/index.js", | |||
There was a problem hiding this comment.
should this file be compiled with babel on publish?
There was a problem hiding this comment.
It only runs on node which supports all the features it utilizes. I'm not sure how useful it is to support a version of node older than 4.
dconnolly
reviewed
Jan 10, 2017
| } | ||
|
|
||
| let keyContent = opt; | ||
| let ints = keyContent.match(/^0?x?(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})(.{2})/i); |
There was a problem hiding this comment.
I'm not jazzed about these regexes...
| } else { | ||
| ivContent = opt; | ||
| } | ||
| let ints = ivContent.match(/^0?x?(.{8})(.{8})(.{8})(.{8})/i); |
There was a problem hiding this comment.
Yeah not jazzed about regexing these uint32's out...
| function(err, decryptedBytes) { | ||
| // err always null | ||
| if (!err) { | ||
| let data = new Buffer(decryptedBytes); |
There was a problem hiding this comment.
I'm paranoid about this. Can we cast to hex or base64 or a string representation, or add an option for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple utility for decryption of AES encrypted files.