fix: 708 captions multi-byte char fix #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing issues with non-latin 708 captions not being displayed correctly. It appears that the issue that we are not always handling multi-byte characters correctly.
This fix proposes that in the case where we see a multi-byte character without a pre-designated decoder, we send the byte array through a function to turn it into a hex string, and then from there decode it into the character.
Example Test Playlist: https://solutions.brightcove.com/wseymour/708-testing/playlist.m3u8
Before:
![Screenshot 2023-10-12 at 10 47 59 AM](https://cdn.statically.io/img/private-user-images.githubusercontent.com/26021721/274656072-0a887c86-db07-4f72-9cfe-00a678951b8f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NDAxMDMsIm5iZiI6MTcyMDQzOTgwMywicGF0aCI6Ii8yNjAyMTcyMS8yNzQ2NTYwNzItMGE4ODdjODYtZGIwNy00ZjcyLTljZmUtMDBhNjc4OTUxYjhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDExNTY0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0ZDZlZTQyZDBjZGMxODZiZWM1OGQxMTFhNTIxMjExMTA2YzhkN2ZkYjBlMTA1Y2IwZTFhMThlODc1MGJkZjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.x56AVSnQKW2CHWeKzp7d6QEvDa8CtIhKjdEX6XqV9jQ)
After:
![Screenshot 2023-10-12 at 10 46 12 AM](https://cdn.statically.io/img/private-user-images.githubusercontent.com/26021721/274656112-00ef4bae-ebd9-4dfb-8793-73baa1565df8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA0NDAxMDMsIm5iZiI6MTcyMDQzOTgwMywicGF0aCI6Ii8yNjAyMTcyMS8yNzQ2NTYxMTItMDBlZjRiYWUtZWJkOS00ZGZiLTg3OTMtNzNiYWExNTY1ZGY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA4VDExNTY0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM1YWZmZTliMDFhOTA0NWNlYmMwMjdjN2ZiNWJkYjI5MWE5MTViZWNiMmRhMjBhZWFjZDdmNzIwYjJkZWM3N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CUkQdRzCErbjTCqvAjAsOY7kj_ihhP7Zni6zuyqRaUs)