Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9467, Custom validation message in custom prop validator #9470

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

znck
Copy link
Member

@znck znck commented Feb 10, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information: #9467

@posva
Copy link
Member

posva commented Feb 10, 2019

Will close #8726 too

warn(
'Invalid prop: custom validator check failed for prop "' + name + '".',
'Invalid prop: ' + message ,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

const message = result instanceof Error ? result.message : 'custom validator check failed';
warn(`Invalid prop ${name}: ${message}`);

without introducing the interpolation thing?

@MrZyr0
Copy link

MrZyr0 commented Nov 10, 2021

Hi everyone 👋

I am desperately trying to customize my validator error message.
I've browsed many other issues, it doesn't seem to be possible at the moment and the community is working on it.

How far along is the development for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants