-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(util): handle more edge cases in looseEqual()
util and add spec
#9527
Open
jacobmllr95
wants to merge
6
commits into
vuejs:dev
Choose a base branch
from
jacobmllr95:fix-loose-equal-util
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+246
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobmllr95
changed the title
fix(utils): Handle more edgecases in
Feb 19, 2019
looseEqual()
util and add spec
Merged
18 tasks
posva
reviewed
Feb 19, 2019
posva
reviewed
Feb 19, 2019
posva
reviewed
Feb 19, 2019
18 tasks
tmorehouse
reviewed
Mar 12, 2019
@posva @yyx990803 Since the same changes landed in Vue v3 it would be awesome to have them in Vue v2.7 too. Ref: vuejs/core#379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR makes the
looseEqual()
util more bulletproof and adds an extra spec for it.The previous implementation failed at following tests:
Performance should also be equal or slightly better because early exits are used wherever possible:
https://jsperf.com/looseequal-comparison
Shoutout to @tmorehouse for helping with the tests and handling all the edge cases.