Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"once" in event listener option #1

Closed
sqal opened this issue Dec 14, 2016 · 1 comment
Closed

"once" in event listener option #1

sqal opened this issue Dec 14, 2016 · 1 comment
Assignees
@johnleider
Labels
T: enhancement Functionality that enhances existing features

Comments

@sqal
Copy link

sqal commented Dec 14, 2016 •
edited
Loading

I have noticed that here L72 you're using once option in addEventListener function. The thing is. This option is not well supported as you can see here - http://caniuse.com/#feat=once-event-listener so in many browsers, added event listeners like this are not going to remove themselves, so you're going to have memory leak right there. It's worth to refactor.
@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Dec 14, 2016
@johnleider
Copy link
Member

Resolved with commit b369f0.
@abelovic abelovic mentioned this issue May 10, 2017
Closed
@johnleider johnleider mentioned this issue May 31, 2017
Closed
@jijoel jijoel mentioned this issue Jun 3, 2017
Closed
@nekosaur nekosaur mentioned this issue Aug 14, 2017
Closed
@caseydwyer caseydwyer mentioned this issue Aug 18, 2017
Closed
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Sep 4, 2017
Closed
@joshas joshas mentioned this issue Nov 8, 2017
Closed
@pentool pentool mentioned this issue Nov 28, 2017
Closed
@Kasheftin Kasheftin mentioned this issue Feb 5, 2018
Closed
@nickgr6 nickgr6 mentioned this issue May 28, 2018
Closed
johnleider pushed a commit that referenced this issue Oct 2, 2018
@ntadic
Merge pull request #1 from ntadic/ntadic-patch-1
a71473d 
Added Serbian cyrilic translation.
@johnleider johnleider mentioned this issue Oct 6, 2018
Closed
KaelWD pushed a commit that referenced this issue Oct 28, 2018
@ChavaSobreyra @KaelWD
Merge pull request #1 from ChavaSobreyra/chava
32e3c60 
i18n Hookup, Homepage, Component Doc Component
@guardiandesecretos guardiandesecretos mentioned this issue Dec 20, 2018
Closed
@ascott18 ascott18 mentioned this issue Jan 17, 2019
Closed
@pSnehanshu pSnehanshu mentioned this issue May 17, 2019
Closed
@lbssousa lbssousa mentioned this issue Sep 2, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2019
@johnleider johnleider self-assigned this Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
3 participants
@sqal @johnleider @KaelWD