-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VBtnGroup): add direction prop #17878
base: dev
Are you sure you want to change the base?
feat(VBtnGroup): add direction prop #17878
Conversation
The buttons are too squished in vertical mode It looks like it's caused by VBtnGroup setting VBtn default height prop value to |
@nekosaur - I concur with your observation. Please suggest. |
export const makeVBtnGroupProps = propsFactory({ | ||
divided: Boolean, | ||
direction: { | ||
type: String as PropType<'horizontal' | 'vertical'>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be have a better dev experience if vertical was a boolean. Spelling out props and attributes ripe for spelling bugs; thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. But for the sake of uniformity, have implemented direction
prop as utilized in VTimeline, VWindow, VSlideGroup and other Vuetify components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be have a better dev experience if vertical was a boolean. Spelling out props and attributes ripe for spelling bugs; thoughts?
I'd normally agree with you but it's too far out for that type of change. With that being said, I'm not sure why we didn't make it boolean.
Any progress on this? |
Also need this. Using this hack:
|
fixes #17492
Description
Added direction prop (allowed values: 'horizontal' | 'vertical')
Markup: