feat(VSkeletonLoader): add types prop to v-skeleton-loader #18878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vuetify 2 included the prop
types
which allowed you to define and use your own custom skeleton types with the existing types that Vuetify provides. This prop was not present in Vuetify 3.In the component, I merge the custom
types
prop into therootTypes
and set that as a computed to keep it reactive.I opted to move the gen* functions into
setup
to inherit themergedTypes
computed rather than pass it around as an extra parameter. Happy to set it up as a parameter instead if desired.I'm not sure if there's anything I need to do on the documentation. I saw that there was already a description for the types prop in
api-generator/src/locale/en/VSkeletonLoader.json
Markup: