-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VStepper): pass item props from item objects #19037
base: dev
Are you sure you want to change the base?
feat(VStepper): pass item props from item objects #19037
Conversation
Hmm, unrelated tests fail, please let me know what to do about that. |
I'm not a maintainer but if you rebase on main (if possible); the pipeline should trigger again and hopefully pass :) I'm also waiting for this to be merged, thanks for your fix @mringler |
1ff7700
to
c165f80
Compare
@captainlettuce Thanks for the tip! Changed to master, which apparently does not run tests at all. Problem solved (kind of). |
I feel this implementation should match what we do with v-list, where we have an item-props property
|
83a7473
to
190087b
Compare
@johnleider Thank you for the feedback, I have updated code and tests. |
134cb52
to
1dc810b
Compare
As a true feature, this will also need to go to the |
1dc810b
to
c0a621c
Compare
@johnleider No worries, thanks for letting me know. Rebased to dev and changed merge target. |
Description
fixes #19036 (see for problem description)
Implementation is straight-forward: If items are objects, their properties are filtered by prop names of VStepperItem and added to the internal item.
Tests are added to ensure string items still work and props are taken over as expected.
Markup:
Notes:
item-props
prop has to be used to enable takeover whole or in parts. This makes sense for lists, which are often generated using existing data, like a list of purchases. I am not sure if it makes sense for a stepper, which is generally not created from unrelated data objects. But I can easily add it if requested.items
variable tointernalItems
, since the worditem
is somewhat overused in the component (there are "items" in props, returned from useGroup, and the internal items), , but I am not sure if this is the place to do it (is it?).This is my first contribution, please let me know what I am doing wrong!
Thank you for Vuetify! I enjoy it a lot.