Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VVideo): add new component #5785

Closed
wants to merge 6 commits into from
Closed

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 2, 2018

Description

Add new v-video component for playing videos.

Motivation and Context

Fixes #5592

How Has This Been Tested?

Visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-app>
    <v-content>
      <v-video ref="vid" autoplay loop muted src="https://www.quirksmode.org/html5/videos/big_buck_bunny.mp4">
      </v-video>
      <v-btn @click="$refs.vid.play()">Play</v-btn>
      <v-btn @click="$refs.vid.pause()">Pause</v-btn>
    </v-content>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project. (I don't know)
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
add new VVideo component for playing videos

Resolves vuetifyjs#5592
@vercel
Copy link

vercel bot commented Dec 2, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@johnleider
Copy link
Member

I appreciate the initiative on this one. We haven't yet determined if we want this component and if we did, what features it should have. We can leave it up for now so we can at least discuss and determine what it would look like if we proceeded forward.

@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #5785 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5785      +/-   ##
==========================================
- Coverage   88.54%   88.51%   -0.04%     
==========================================
  Files         281      283       +2     
  Lines        6163     6172       +9     
  Branches     1532     1532              
==========================================
+ Hits         5457     5463       +6     
- Misses        588      591       +3     
  Partials      118      118
Impacted Files Coverage Δ
packages/vuetify/src/components/index.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VVideo/index.ts 100% <100%> (ø)
packages/vuetify/src/components/VVideo/VVideo.ts 40% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bfaf8...054aa33. Read the comment docs.

@johnleider johnleider changed the title feat: add v-video component Dec 2, 2018
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #5785 into dev will increase coverage by 5.69%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5785      +/-   ##
==========================================
+ Coverage   82.59%   88.29%   +5.69%     
==========================================
  Files         292      281      -11     
  Lines        7011     6329     -682     
  Branches     1724     1594     -130     
==========================================
- Hits         5791     5588     -203     
+ Misses       1087      623     -464     
+ Partials      133      118      -15
Impacted Files Coverage Δ
packages/vuetify/src/components/index.ts 100% <100%> (ø) ⬆️
packages/vuetify/src/components/VVideo/index.ts 100% <100%> (ø)
packages/vuetify/src/components/VVideo/VVideo.ts 40% <40%> (ø)
.../vuetify/src/components/VSparkline/helpers/core.ts 10% <0%> (-90%) ⬇️
.../vuetify/src/components/VSparkline/helpers/path.ts 13.33% <0%> (-75.56%) ⬇️
.../vuetify/src/components/VSparkline/helpers/math.ts 30% <0%> (-70%) ⬇️
...es/vuetify/src/components/VSparkline/VSparkline.ts 5.55% <0%> (-28.79%) ⬇️
packages/vuetify/src/components/VMenu/VMenu.js 83.63% <0%> (-7.44%) ⬇️
packages/vuetify/src/components/VDialog/VDialog.js 72% <0%> (-4.32%) ⬇️
packages/vuetify/src/components/VAlert/VAlert.ts 96.29% <0%> (-3.71%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b89c5...e1f71e4. Read the comment docs.

@johnleider johnleider added T: feature A new feature and removed T: feature A new feature labels Dec 2, 2018
@dsseng
Copy link
Contributor Author

dsseng commented Feb 24, 2019

@johnleider is this required?

@dsseng dsseng added T: feature A new feature and removed T: feature A new feature labels Mar 4, 2019
@MajesticPotatoe MajesticPotatoe added S: on hold The issue is on hold until further notice pending team review The issue is pending a full team review labels Mar 19, 2019
@dsseng dsseng added this to the v2.x.x milestone Apr 23, 2019
@johnleider
Copy link
Member

Thank you for the Feature Request and interest in improving Vuetify. After careful consideration the team has decided that this is not functionality that we are looking to implement at this time.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider closed this Jun 10, 2019
@dsseng dsseng deleted the feat/v-video branch June 11, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending team review The issue is pending a full team review S: on hold The issue is on hold until further notice T: feature A new feature
3 participants