-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VVideo): add new component #5785
Conversation
add new VVideo component for playing videos Resolves vuetifyjs#5592
This pull request is automatically deployed with Now. |
I appreciate the initiative on this one. We haven't yet determined if we want this component and if we did, what features it should have. We can leave it up for now so we can at least discuss and determine what it would look like if we proceeded forward. |
add new VVideo component for playing videos Resolves vuetifyjs#5592
Codecov Report
@@ Coverage Diff @@
## dev #5785 +/- ##
==========================================
- Coverage 88.54% 88.51% -0.04%
==========================================
Files 281 283 +2
Lines 6163 6172 +9
Branches 1532 1532
==========================================
+ Hits 5457 5463 +6
- Misses 588 591 +3
Partials 118 118
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #5785 +/- ##
==========================================
+ Coverage 82.59% 88.29% +5.69%
==========================================
Files 292 281 -11
Lines 7011 6329 -682
Branches 1724 1594 -130
==========================================
- Hits 5791 5588 -203
+ Misses 1087 623 -464
+ Partials 133 118 -15
Continue to review full report at Codecov.
|
@johnleider is this required? |
Thank you for the Feature Request and interest in improving Vuetify. After careful consideration the team has decided that this is not functionality that we are looking to implement at this time. If you have any additional questions, please reach out to us in our Discord community. |
Description
Add new
v-video
component for playing videos.Motivation and Context
Fixes #5592
How Has This Been Tested?
Visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).