Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-3][masonry] merge masonry-auto-flow into grid-auto-flow? #10231

Closed
fantasai opened this issue Apr 19, 2024 · 4 comments
Closed

[css-grid-3][masonry] merge masonry-auto-flow into grid-auto-flow? #10231

fantasai opened this issue Apr 19, 2024 · 4 comments

Comments

@fantasai
Copy link
Collaborator

The masonry-auto-flow property does something similar to grid-auto-flow; should we merge these two properties?

@SelenIT
Copy link
Collaborator

SelenIT commented Apr 22, 2024

There was once an idea to use the special grid-auto-flow value as the only masonry switch, with no extra values to grid-*-template and no extra properties at all. Maybe it could be worth reconsidering?

@fantasai
Copy link
Collaborator Author

fantasai commented May 7, 2024

If we drop definite-first (#10260) and we drop next (#10232) then we can just drop the property entirely.

@tabatkins
Copy link
Member

tabatkins commented Jun 25, 2024

These shouldn't be merged, imo. They're doing the same things, conceptually, but have a totally different set of controls for those things. We'd just have two divergent syntax branches, with one useful only for Grid and the other useful only for Masonry; we'd have to define default behavior for if you used the wrong set of keywords. That doesn't suggest they're actually useful to be in the same property.

(This is ignoring the larger issue about Masonry being a different display type in the first place; regardless of that, I think they're still best as separate properties. But if it is a separate display type, they're clearly best as separate properties imo.)

(But also, as you say, we can just drop the property entirely if we switch over to masonry-threshold, since we have already dropped the definite-first switch.)

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed [css-grid-3][masonry] merge masonry-auto-flow into grid-auto-flow?, and agreed to the following:

  • RESOLVED: Drop masonry-auto-flow
The full IRC log of that discussion <flackr> fantasai: now that we've dropped the definite value and the next value, there's nothing for masonry-auto-flow to do, so propose dropping property altogether
<TabAtkins> I like a property with no choice in its syntax. `Value: foo bar` , no | anywhere, perfection
<flackr> astearns: any concerns about dropping masonry-auto-flow?
<flackr> astearns: objections?
<flackr> RESOLVED: Drop masonry-auto-flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment