Change Report and ReportBody interfaces to dicts. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes any suggestion that the two interface names (and the names of those interfaces which inherit from `ReportBody`) should be exposed on the global object. `ReportBody` is purely abstract, and exists so that it can be used as the type of the `body` member of `Report`, while still allowing other specifications to define new subtypes for their own report types. Closes: #216
|
@cdumez @brentfulgham FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes any suggestion that the two interface names (and the names of those interfaces which inherit from
ReportBody) should be exposed on the global object.ReportBodyis purely abstract, and exists so that it can be used as the type of thebodymember ofReport, while still allowing other specifications to define new subtypes for their own report types.Closes: #216
Preview | Diff