Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InitiatorType of service worker navigation preload #110

Closed
horo-t opened this issue Apr 27, 2017 · 4 comments
Closed

InitiatorType of service worker navigation preload #110

horo-t opened this issue Apr 27, 2017 · 4 comments
Labels
Clarification needs tests
Milestone
Level 2

Comments

@horo-t
Copy link
Member

horo-t commented Apr 27, 2017

I'm trying to expose the timing information of service worker navigation preload responses.
https://crbug.com/712809

According to the current spec, the initiatorType of the PerformanceResourceTiming of the preload responses must be "other".
But I think it is more convenient if we can use "navigationpreload" or something like it.
@igrigorik
Copy link
Member

Still trying to wrap my head around implications of "navigation preload", but on first pass.. shouldn't the initiator be "navigation". From what I understand, the navigation proceeds in parallel with the worker startup, so initiator shouldn't change..
@toddreifsteck
Copy link
Member

@yoavweiss and Ryosuke agreed that a note could help clarify Ilya's suggestion for implementors.
@toddreifsteck toddreifsteck added this to the Level 2 milestone Nov 7, 2017
This was referenced Feb 26, 2018
Closed
Closed
@yoavweiss
Copy link
Contributor

Related Chromium change (including tests): https://chromium-review.googlesource.com/c/chromium/src/+/941342
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Feb 28, 2018
@yoavweiss @chromium-wpt-export-bot
Change navigation preload initiatorType to "navigation"
2fa5ae3 
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 2, 2018
@yoavweiss @chromium-wpt-export-bot
Change navigation preload initiatorType to "navigation"
b59e326 
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 2, 2018
@yoavweiss
Change navigation preload initiatorType to "navigation"
c78bcdb 
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 2, 2018
@yoavweiss @chromium-wpt-export-bot
Change navigation preload initiatorType to "navigation"
d2dd9ad 
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 2, 2018
@yoavweiss @chromium-wpt-export-bot
Change navigation preload initiatorType to "navigation"
34c346b 
As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 1, 2018
@yoavweiss @jgraham
Bug 1441859 [wpt PR 9717] - Change navigation preload initiatorType t…
0a9858e 
…o "navigation", a=testonly

Automatic update from web-platform-testsChange navigation preload initiatorType to "navigation"

As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540483}

wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
@yoavweiss
Copy link
Contributor

I tried to add a note, but it seemed out of place, and something that really belonged in Fetch. Looking at Fetch, the "navigation" destination seems to just fall off the definition and a note seemed spurious.

With the tests in place to make sure implementations won't get it wrong in the future, I now feel a note is not really necessary.

Closing, but feel free to reopen if you disagree.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1441859 [wpt PR 9717] - Change navigation preload initiatorType t…
780bb99 
…o "navigation", a=testonly

Automatic update from web-platform-testsChange navigation preload initiatorType to "navigation"

As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoavyoav.ws>
Reviewed-by: Tsuyoshi Horo <horochromium.org>
Reviewed-by: Marijn Kruisselbrink <mekchromium.org>
Cr-Commit-Position: refs/heads/master{#540483}

wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717

UltraBlame original commit: a4956611bf5aa9d4e199809b87d28c373ca39a32
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1441859 [wpt PR 9717] - Change navigation preload initiatorType t…
2a9d57e 
…o "navigation", a=testonly

Automatic update from web-platform-testsChange navigation preload initiatorType to "navigation"

As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoavyoav.ws>
Reviewed-by: Tsuyoshi Horo <horochromium.org>
Reviewed-by: Marijn Kruisselbrink <mekchromium.org>
Cr-Commit-Position: refs/heads/master{#540483}

wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717

UltraBlame original commit: a4956611bf5aa9d4e199809b87d28c373ca39a32
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
@marco-c
Bug 1441859 [wpt PR 9717] - Change navigation preload initiatorType t…
892990d 
…o "navigation", a=testonly

Automatic update from web-platform-testsChange navigation preload initiatorType to "navigation"

As discussed at w3c/resource-timing#110
the Resource Timing specification does not single out navigation
preload from other navigation types, and therefore the `initiatorType`
for it should be "navigation", rather than other.

This CL implements that change.

Intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/W3InszDnV2k/AuJg4aAMDQAJ

Change-Id: Iba7fa038892936e164cd408355f1ac9f6592415b
Reviewed-on: https://chromium-review.googlesource.com/941342
Commit-Queue: Yoav Weiss <yoavyoav.ws>
Reviewed-by: Tsuyoshi Horo <horochromium.org>
Reviewed-by: Marijn Kruisselbrink <mekchromium.org>
Cr-Commit-Position: refs/heads/master{#540483}

wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717
wpt-commits: 34c346b8485a2c77e14d4c6d188773fc5465b5b0
wpt-pr: 9717

UltraBlame original commit: a4956611bf5aa9d4e199809b87d28c373ca39a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clarification needs tests
5 participants
@igrigorik @yoavweiss @nicjansma @toddreifsteck @horo-t