Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export setup function #265

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Export setup function #265

merged 2 commits into from
Apr 8, 2021

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Apr 8, 2021 •
edited by pr-preview bot
Loading

@noamr noamr requested a review from yoavweiss April 8, 2021 08:50
yoavweiss
yoavweiss approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit
index.html Outdated
<li><a data-lt='add a PerformanceResourceTiming entry'>Add</a> the
<a>PerformanceResourceTiming</a> object to |global|'s
"PERFORMANCE-TIMELINE-2#dfn-queue-a-performanceentry">Queue</a> |entry|.</li>
<li><a data-lt='add a PerformanceResourceTiming entry'>Add</a> |entry| object to |global|'s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think you can drop "object" here
@noamr noamr merged commit d9b9c06 into gh-pages Apr 8, 2021
@noamr noamr deleted the export-ctor branch April 8, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@noamr @yoavweiss