Add a revalidation cache state and adapt transferSize to it #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
May 12, 2021
For Resource Timing's transferSize. Corresponding RT PR: w3c/resource-timing#272. Tests: https://chromium-review.googlesource.com/c/chromium/src/+/2878693.
|
@achristensen07 - I missed the fact that this PR hasn't landed yet in yesterday's call. Can you maybe take a look? |
nicjansma
approved these changes
Jul 12, 2021
yoavweiss
force-pushed
the
revalidation_cache_state
branch
from
790a186
to
5cdc106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary PR to whatwg/fetch#1232
While implementing the recent Resource Timing transferSize changes, I realized that the current spec is not sufficient to implement what was discussed in the WG, and more importantly, insufficient to maintain backwards compatibility with current transferSize values.
Essentially, we want transferSize to return different values for the cases of local caching (in which case it needs to return 0), full fetch from the network (in which case it needs to return the encoded body size + a constant) as well as the successful revalidation case (where it needs to return just the constant representing the headers used to revalidate the response).
Preview | Diff