Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tidy up spec #278

Merged
merged 2 commits into from
Jul 7, 2021
Merged

chore: tidy up spec #278

merged 2 commits into from
Jul 7, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jun 30, 2021 •
edited by pr-preview bot
Loading

Run of tidy, plus silence some ReSpec warnings.

Preview | Diff
@marcoscaceres
Copy link
Member Author

Failing because of #279
yoavweiss
yoavweiss approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@marcoscaceres marcoscaceres merged commit edea639 into gh-pages Jul 7, 2021
@marcoscaceres marcoscaceres deleted the tidy branch July 7, 2021 01:04
@marcoscaceres marcoscaceres restored the tidy branch July 13, 2021 07:22
@marcoscaceres marcoscaceres deleted the tidy branch July 13, 2021 07:24
@marcoscaceres marcoscaceres mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@marcoscaceres @yoavweiss