-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 4.2 non-normative #290
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Make 4.2 non-normative
Closes #256
- Loading branch information
commit acfc532832d3bc9a5211d8dc1d5e71266feebeac
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -287,27 +287,25 @@ <h3> | |
Resources Included in the <a>PerformanceResourceTiming</a> Interface | ||
</h3> | ||
<p> | ||
All resource [=Request=]s [=fetch=]ed by a non-null | ||
[=request/client=] MUST be included as | ||
This section is non-normative. | ||
</p> | ||
<p> | ||
Resource [=Request=]s [=fetch=]ed by a non-null [=request/client=] should be included as | ||
<a>PerformanceResourceTiming</a> objects in the [=request/client=]'s | ||
[=environment settings object/global object=]'s <a data-cite= | ||
"PERFORMANCE-TIMELINE-2#performance-timeline">Performance | ||
Timeline</a>, unless excluded from the timeline as part of the | ||
[=fetch|fetching process=]. Resources that are retrieved from | ||
<a data-cite="HTML#relevant-application-cache">relevant application | ||
caches</a> or local resources MUST be included as | ||
caches</a> or local resources should also be included as | ||
<a>PerformanceResourceTiming</a> objects in the <a data-cite= | ||
"PERFORMANCE-TIMELINE-2#performance-timeline">Performance | ||
Timeline</a> [[PERFORMANCE-TIMELINE-2]]. Resources for which the | ||
[=fetch=] was initiated, but was later aborted (e.g. due to a network | ||
error) MAY be included as <a>PerformanceResourceTiming</a> objects in | ||
error) should be included as <a>PerformanceResourceTiming</a> objects in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/should be/are/ |
||
the <a data-cite= | ||
"PERFORMANCE-TIMELINE-2#performance-timeline">Performance | ||
Timeline</a> and MUST contain initialized attribute values for | ||
processed substeps of the [=fetch|fetching process=]. | ||
</p> | ||
<p> | ||
The rest of this section is non-normative. | ||
Timeline</a>, with their start and end timing. | ||
</p> | ||
<p> | ||
Examples: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/should also be/are/?