Fix a link to the HR-TIME spec #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Performance Timeline Level 2 spec needs to get referenced through 'performance-timeline', not 'performance-timeline-2' ... see https://respec.org/xref/?term=supportedEntryTypes ...🤷 Checks are green now 😄! |
|
Yeah, I think we recently removed the "-2" |
|
Gah! Didn't realize force-pushing to my github repo would update the PR here... working to revert now... |
|
Sorry for the noise hear Yoav 😅 Does this look mergeable now? |
npm1
reviewed
Jan 10, 2022
|
I've added npm1's suggestion to reference HR-Time's definition without the LMKWYT! |
npm1
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link goes to the HR-TIME spec but the URL fragment was missing a prefix so it didn't auto-scroll to the targeted definition.
Preview | Diff