Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused definitions and other respec errors #310

Merged
merged 7 commits into from
Jan 12, 2022
Merged

Clean up unused definitions and other respec errors #310

merged 7 commits into from
Jan 12, 2022

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Jan 11, 2022 •
edited by pr-preview bot
Loading

@yoavweiss yoavweiss changed the title Clean up unused definitiona and other respec errors Jan 11, 2022
@yoavweiss yoavweiss requested a review from npm1 January 11, 2022 16:26
npm1
npm1 reviewed Jan 11, 2022
View reviewed changes
index.html
known. [[ECMASCRIPT]]
</p>
<p>
The term <dfn>resource</dfn> is used to refer to elements and any other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to delete this but does this API still have a clear explanation about what resources are exposed via ResourceTiming?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface seems to cover it
index.html Outdated
elements [[HTML]] such as iframe, img, script, object, embed, and link
with the link type of stylesheet, and SVG elements [[SVG11]] such as
svg.
</p>
<p>
The term <dfn>cross-origin</dfn> is used to mean non [=same origin=].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? It seems like something that ought to be defined elsewhere.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we can remove it. HTML and Fetch are not specifically defining it, so we probably don't have to
index.html
<dfn>"css"</dfn>, if the request is a result of processing a CSS
<a data-xref-type="css-function">url()</a> directive such as
<code>"css"</code>, if the request is a result of processing a CSS
<a data-cite="css-values-4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not exported? If it isn't maybe file a bug against that repo?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exported in both css-values-3 and css-values-4, which seems to create confusion in specref. Talking to @marcoscaceres, this is the syntax we want here..
index.html
<code>@import url()</code> or <code>background: url()</code>;
[[CSS-VALUES]]
</li>
<li>
<dfn>"script"</dfn>, if the request is a result of loading any
<code>"script"</code>, if the request is a result of loading any
<a data-cite="HTML#concept-script">script</a> (a classic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto exported?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exported, but respec can't deal with [=script=]. We can deal with it as a followup.
/cc @marcoscaceres
index.html
@@ -1097,7 +1069,7 @@ <h2>
"PERFORMANCE-TIMELINE-2#dfn-queue-a-performanceentry">Queue</a>
|entry|.
</li>
<li>Add |entry| to |global|'s <a data-cite=
<li>[=Add a PerformanceResourceTiming entry|Add=] |entry| to |global|'s <a data-cite=
"PERFORMANCE-TIMELINE-2#dfn-performance-entry-buffer">performance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto exported?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed w3c/performance-timeline#196. Let's deal with it in a followup, as this is not the only place citing it.
@yoavweiss yoavweiss merged commit 3b51fc4 into w3c:gh-pages Jan 12, 2022
yoavweiss added a commit to yoavweiss/resource-timing that referenced this pull request Jan 12, 2022
@yoavweiss
Merge branch 'gh-pages' of github.com:w3c/resource-timing into gh-pages
12d4ca5 
* 'gh-pages' of github.com:w3c/resource-timing:
  Clean up unused definitions and other respec errors (w3c#310)
  chore: tidy up index.html (w3c#309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@yoavweiss @npm1