Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List all the attributes that will get masked when TAO fails #311

Merged
merged 4 commits into from
Jan 13, 2022
Merged

List all the attributes that will get masked when TAO fails #311

merged 4 commits into from
Jan 13, 2022

Conversation

tommckee1
Copy link
Member

@tommckee1 tommckee1 commented Jan 12, 2022 •
edited by pr-preview bot
Loading

Although the 'note' is non-normative, it's helpful for folks to see a more comprehensive list, IMO.

LMKWYT!

Preview | Diff
yoavweiss
yoavweiss reviewed Jan 13, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss reviewed Jan 13, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
yoavweiss
yoavweiss approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit
index.html Outdated
Performance Timeline</a>. If the <a
data-cite="FETCH#concept-tao-check">timing allow check</a> algorithm
fails for a cross-origin resource, the entry will be an
<a data-cite="FETCH#create-an-opaque-timing-info">opaque entry</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: replace the data-cite with [=create an opaque timing info|opaque entry=]
@yoavweiss yoavweiss merged commit cb5502e into w3c:gh-pages Jan 13, 2022
@yoavweiss
Copy link
Contributor

Thanks for fixing this up!! :)
yoavweiss added a commit to yoavweiss/resource-timing that referenced this pull request Jan 14, 2022
@yoavweiss
Merge branch 'gh-pages' of github.com:w3c/resource-timing into gh-pages
2352d9d 
* 'gh-pages' of github.com:w3c/resource-timing:
  chore: tidy up index.html (w3c#314)
  List all the attributes that will get masked when TAO fails (w3c#311)
  chore: tidy up index.html (w3c#313)
  Fix up a missing section (w3c#312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@tommckee1 @yoavweiss